Update CI workflow for PHP versions #17
Conversation
Add PHP 8.3 to old_stable and update current_stable to PHP 8.4. This ensures compatibility checks with the latest PHP versions.
📝 Walkthrough📝 WalkthroughWalkthroughこのプルリクエストでは、 Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🧰 Additional context used🪛 GitHub Check: codecov/patchsrc/Halo/HaloRenderer.php[warning] 146-146: src/Halo/HaloRenderer.php#L146 [warning] 150-150: src/Halo/HaloRenderer.php#L150 🔇 Additional comments (2)src/Halo/HaloRenderer.php (2)
コールバック関数の改善が必要です 以下の点について確認と改善が必要です：
以下の変更を提案します： - /** @param array<int|string, string> $matches */
- static function ($matches): string {
+ /** @param array{1: string} $matches */
+ static function (array $matches): string {
$uri = substr(explode(' ', $matches[1])[0], 1);
preg_match('/ <!-- resource_body_start -->(.*?)<!-- resource_body_end -->/s', $matches[1], $resourceBodyMatch);
if (! isset($resourceBodyMatch[1])) {
throw new LogicException('Resource body not found'); // @codeCoverageIgnore
}
- return ''; // not used but needed for the callback signature
+ return $resourceBodyMatch[1];
},また、以下のテストケースの追加を推奨します： public function testAddResourceMetaInfoWithMissingBody(): void
{
$this->expectException(LogicException::class);
$this->expectExceptionMessage('Resource body not found');
// テストケースの実装をご希望の場合は、お申し付けください
}実装の影響を確認するために、以下のスクリプトを実行してください： 🧰 Tools🪛 GitHub Check: codecov/patch[warning] 146-146: src/Halo/HaloRenderer.php#L146 [warning] 150-150: src/Halo/HaloRenderer.php#L150 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==============================================
- Coverage 100.00% 87.29% -12.71%
- Complexity 29 81 +52
==============================================
Files 5 8 +3
Lines 117 307 +190
==============================================
+ Hits 117 268 +151
- Misses 0 39 +39 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Eliminated the 'twigPaths' parameter from the #[TwigPaths] attribute for cleaner code. This change simplifies the constructor definition and improves readability.
Bumped versions for several Composer dependencies including `composer/pcre`, `composer/semver`, and `symfony/config`. This update ensures compatibility with new features and fixes in these libraries, and adjusts `require-dev` settings and conflict resolutions accordingly.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This update introduces a LogicException to handle cases where the resource body is not found in the provided HTML snippet. This ensures the code fails gracefully with a clear error message if the expected resource body is missing, improving the robustness of the rendering functionality.
Updated the plugin-api-version in two composer.lock files from 2.2.0 to 2.6.0. This also included changes in 'platform' and 'platform-dev' fields from empty arrays to empty objects.
Add PHP 8.3 to old_stable and update current_stable to PHP 8.4. This ensures compatibility checks with the latest PHP versions.